feat: use the Connect signaturePrivateKey as an additional owner in the smart account #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For now I've changed it so that keys are stored in sessionStorage - we still need to work on ensuring it's secure, but it's a bit better as they will be wiped when a tab is closed. The UX is also not too bad as the consequence of wiping the keys is a single wallet signature to decrypt them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Branching from #253 - we should merge that one first)
This makes the Connect app behave a lot more like a browser wallet like Privy or Metamask.
We'll need to think very carefully about how to secure these credentials client-side (e.g. CSP), but we already have that problem for the all the identity keys in the application.
We should make sure users are aware that the Connect app is given full admin access to the Geo smart account, the keys live in the browser window and are only stored on the sync server encrypted.
Maybe it would be better to not store the keys in localStorage? then the user would always have to sign to decrypt in every Connect flow, but after that they don't need to sign any other transactions or messages.